Fix two-way stream cancelation and pings #19763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not log errors on oneway streams when sending ping fails. Instead cancel the stream. This also makes sure pings are sent when blocked on sending responses. I will do a separate PR that includes this and adds pings to two-way streams as well as tests for pings.
# Conflicts: # internal/grid/muxclient.go
# Conflicts: # internal/grid/muxclient.go
|
PTAL @poornas |
poornas
approved these changes
May 22, 2024
harshavardhana
approved these changes
May 22, 2024
harshavardhana
added a commit
to shtripat/minio
that referenced
this pull request
May 22, 2024
This reverts commit 4d69884.
harshavardhana
added a commit
that referenced
this pull request
May 22, 2024
This reverts commit 4d69884.
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
May 22, 2024
This reverts commit ae14681.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@harshavardhana Not urgent. This can wait until after next release.
Rewrite two-way stream ping and add tests. Currently these streams are not used.
Motivation and Context
Stability and for future features.
How to test this PR?
Types of changes