[stdlib] Improve tests for utils.numerics
#2680
Assignees
Labels
good first issue
Good for newcomers
mojo-repo
Tag all issues with this label
mojo-stdlib
Tag for issues related to standard library
Comments
laszlokindrat
added
good first issue
|
@laszlokindrat can I work on it? |
This was referenced May 17, 2024
|
PR ready for review: #2727 |
modularbot
pushed a commit
that referenced
this issue
May 18, 2024
[External] [stdlib][NFC] Improve tests for utils.numerics ## Changes - [X] Alpha order on `test_simd.mojo` to easier overview - [X] Tests for `get_accum_type()`, `mex_or_inf()`, `min_finite()`, `min_or_neg_inf()`, `nextafter()` and `neg_inf()` ## Ref See #2680 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2727 MODULAR_ORIG_COMMIT_REV_ID: cc66c1163ae663010cac482518b57fbedb0aa636
|
I think we can close it, right? |
msaelices
added a commit
to msaelices/mojo
that referenced
this issue
May 18, 2024
[External] [stdlib][NFC] Improve tests for utils.numerics ## Changes - [X] Alpha order on `test_simd.mojo` to easier overview - [X] Tests for `get_accum_type()`, `mex_or_inf()`, `min_finite()`, `min_or_neg_inf()`, `nextafter()` and `neg_inf()` ## Ref See modularml#2680 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2727 MODULAR_ORIG_COMMIT_REV_ID: cc66c1163ae663010cac482518b57fbedb0aa636
Yes, thank you for fixing it! |
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this issue
May 24, 2024
[External] [stdlib][NFC] Improve tests for utils.numerics ## Changes - [X] Alpha order on `test_simd.mojo` to easier overview - [X] Tests for `get_accum_type()`, `mex_or_inf()`, `min_finite()`, `min_or_neg_inf()`, `nextafter()` and `neg_inf()` ## Ref See modularml#2680 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2727 MODULAR_ORIG_COMMIT_REV_ID: cc66c1163ae663010cac482518b57fbedb0aa636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Most functionality in this module is either poorly or not at all tested (and it's possible that some tests are misplaced somewhere else, e.g.
test_simd.mojo). We should improve the coverage on this module and organize the test cases better.See comment: a2b9d3b#diff-
f25d998fb073a68a1aaa3cabd5203651034b0e2b55d67be3ecfce89ef99139faR20
The text was updated successfully, but these errors were encountered: