[stdlib][NFC] Tests for the abs() round() and divmod() math functions #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
|
@msaelices Thanks for the patch! Something is wrong with the commit, could you please ensure that CI passes? |
laszlokindrat
changed the title
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
May 22, 2024
…h functions (#40350) [External] [stdlib][NFC] Tests for the abs() round() and divmod() math functions All of these functions call to the specific `__abs__`, `__round__` and `__divmod__` methods depending on the types involved. These are some smoke tests to make sure they do not accidentally break See ticket #2679 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2724 MODULAR_ORIG_COMMIT_REV_ID: 476d782383800dc7a6e39aaa8f0fca4c1a713844
|
Landed in 5beb1ae! Thank you for your contribution 🎉 |
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…h functions (#40350) [External] [stdlib][NFC] Tests for the abs() round() and divmod() math functions All of these functions call to the specific `__abs__`, `__round__` and `__divmod__` methods depending on the types involved. These are some smoke tests to make sure they do not accidentally break See ticket modularml#2679 Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2724 MODULAR_ORIG_COMMIT_REV_ID: 476d782383800dc7a6e39aaa8f0fca4c1a713844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these functions call to the specific
__abs__,__round__and__divmod__methods depending on the types involved.These are some smoke tests to make sure they do not accidentally break
See ticket #2679