[stdlib] Tuple.__contains__

[rd4com]

Hello,

here is an implementation of Tuple.__contains__,

it makes it possible to do:

  var x = Tuple(1,2,True)
  if 1 in x: print("x contains 1")

@laszlokindrat suggested a ping for the PR in #2658

[laszlokindrat]

Pretty cool, thank you!

[rd4com]

@laszlokindrat Yes, sorry, the tests are more complete now, do you see more cases to add ?

There is a test failing in test_list.mojo for macosx, not sure what to do ?

[rd4com]

The force-push worked with the rebased branch 🥳 :

• it includes a new @parameter optimization that returns false if T not in self.element_types
  (before var result:Bool = False)
• no rebind of memory-only types, we rebind the Reference, which is @register_passable

Todo:

• when @parameter for can do returns, we will be able to return True the first time that self[i] == value,
  instead of continuing doing result |= for every _type_is_eq[element_types[i],T]().
  There would be no need for var result:Bool

ℹ️ Note that the rebase is on 2024.5.1805 not 2024.5.1905

[laszlokindrat]

!sync

[laszlokindrat]

Thanks again! I think this is a useful functionality, and while we can't do it perfectly yet, it does deliver a useful feature, especially for people coming from Python. There are very likely some sharp edges around the current behavior. If you can think of any, please open a PR to document them.

[rd4com]

@laszlokindrat , This is great! this is a cool feature, i'd be happy to use it too 😄 .
 

Once auto-dereference lands:

• It will probably require some changes, as it might rebind the dereferenced value instead of the Reference.

If there is any way you can add this to sort of a todo list to make sure Tuple.__contains__ still works?

[laszlokindrat]

@laszlokindrat , This is great! this is a cool feature, i'd be happy to use it too 😄 .  

Once auto-dereference lands:

• It will probably require some changes, as it might rebind the dereferenced value instead of the Reference.

If there is any way you can add this to sort of a todo list to make sure Tuple.__contains__ still works?

The tests should prevent it from being broken.

[modularbot]

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

[modularbot]

Landed in ea528b3! Thank you for your contribution 🎉