[stdlib] Add startswith() and endswith() to StringRef
#2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Especially for this PR it would be nice to have a way of creating a var str_ref = String()._strref_dangerous(start, len)In case of See PR #2719 |
Signed-off-by: Lukas Lipp <15105596+fknfilewalker@users.noreply.github.com>
Signed-off-by: Lukas Lipp <llipp@cg.tuwien.ac.at>
JoeLoser
approved these changes
May 21, 2024
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
modularbot
added a commit
that referenced
this pull request
May 23, 2024
…` (#40383) [External] [stdlib] Add `startswith()` and `endswith()` to `StringRef` Also delegates `String` functions to `StringRef` ORIGINAL_AUTHOR=Lukas Lipp <15105596+fknfilewalker@users.noreply.github.com> PUBLIC_PR_LINK=#2710 Co-authored-by: Lukas Lipp <15105596+fknfilewalker@users.noreply.github.com> Closes #2710 MODULAR_ORIG_COMMIT_REV_ID: cb7fd59c23fb5c655a1c0a1d6b5f7601306f6953
|
Landed in bc4c5f7! Thank you for your contribution 🎉 |
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…` (#40383) [External] [stdlib] Add `startswith()` and `endswith()` to `StringRef` Also delegates `String` functions to `StringRef` ORIGINAL_AUTHOR=Lukas Lipp <15105596+fknfilewalker@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2710 Co-authored-by: Lukas Lipp <15105596+fknfilewalker@users.noreply.github.com> Closes modularml#2710 MODULAR_ORIG_COMMIT_REV_ID: cb7fd59c23fb5c655a1c0a1d6b5f7601306f6953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also delegates String functions to StringRef