[stdlib] Fix incorrect number of variadic arguments in SIMD #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
JoeLoser
reviewed
May 20, 2024
JoeLoser
reviewed
May 21, 2024
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
JoeLoser
approved these changes
May 21, 2024
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
|
Landed in 3ed4914! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
May 22, 2024
…D (#40375) [External] [stdlib] Fix incorrect number of variadic arguments in SIMD Fix part of #2687 by changing various SIMD tests that were neither passing `1` or `N` values in the construction of a `SIMD` type (i.e. ones that were passing `k` values where `1 < k < N`). Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes #2720 MODULAR_ORIG_COMMIT_REV_ID: 20baf2934b7d768523a412755e32ffbfb109c0fd
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…D (#40375) [External] [stdlib] Fix incorrect number of variadic arguments in SIMD Fix part of modularml#2687 by changing various SIMD tests that were neither passing `1` or `N` values in the construction of a `SIMD` type (i.e. ones that were passing `k` values where `1 < k < N`). Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes modularml#2720 MODULAR_ORIG_COMMIT_REV_ID: 20baf2934b7d768523a412755e32ffbfb109c0fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #2687
I wonder if it's considered undefined behavior