[stdlib] Allow natural list.__repr__() syntax for List #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for the @staticmethod and the __type_of() trick in List.__repr__() Signed-off-by: Manuel Saelices <msaelices@gmail.com>
msaelices
changed the title
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
|
Landed in 131d8d4! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
May 21, 2024
…0304) [External] [stdlib] Allow natural list.__repr__() syntax for List No need for the `@staticmethod` and the `__type_of()` trick in `List.__repr__()` Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2733 MODULAR_ORIG_COMMIT_REV_ID: 50d64ae606e89dde9f0b5db575f472cf89fbfca5
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…0304) [External] [stdlib] Allow natural list.__repr__() syntax for List No need for the `@staticmethod` and the `__type_of()` trick in `List.__repr__()` Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2733 MODULAR_ORIG_COMMIT_REV_ID: 50d64ae606e89dde9f0b5db575f472cf89fbfca5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for the
@staticmethodand the__type_of()trick inList.__repr__()