[tools] Allow to choose the test files when using run-tests.sh
#2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
|
!sync |
JoeLoser
added
the
imported-internally
JoeLoser
reviewed
May 18, 2024
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in a8f3844! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
May 21, 2024
…ts.sh` (#40225) [External] [tools] Allow to choose the test files when using `run-tests.sh` Also rectified a small mistake in the guide: unlike what was written previously, the contributors don't need to run `lit` after using the script `run-tests.sh`. Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes #2737 MODULAR_ORIG_COMMIT_REV_ID: f0013a6d9c0903bed9392545555810607ec7d8cf
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…ts.sh` (#40225) [External] [tools] Allow to choose the test files when using `run-tests.sh` Also rectified a small mistake in the guide: unlike what was written previously, the contributors don't need to run `lit` after using the script `run-tests.sh`. Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes modularml#2737 MODULAR_ORIG_COMMIT_REV_ID: f0013a6d9c0903bed9392545555810607ec7d8cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rectified a small mistake in the guide: unlike what was written previously, the contributors don't need to run
litafter using the scriptrun-tests.sh.