[stdlib] Replacing StringRef's local _memcmp with memory.memcmp for string comparisons.
#2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
|
!sync |
modularbot
added
the
imported-internally
|
I checked, this is breaking some internal stuff due to the recursion we discussed in #2620. Not sure how to fix it, but I think it has to do with the error printing of the constraint in |
modularbot
added a commit
that referenced
this pull request
Jun 5, 2024
[External] [stdlib] `memcmp` refactor for string comparisons This is a follow-up to #2740. Refactored the `memcmp` implementation to give `StringRef` a `constrained`-less version for vectorized string comparisons that avoid an internal recursion bug. ORIGINAL_AUTHOR=Simon Hellsten <56205346+siitron@users.noreply.github.com> PUBLIC_PR_LINK=#2926 Co-authored-by: Simon Hellsten <56205346+siitron@users.noreply.github.com> Closes #2926 MODULAR_ORIG_COMMIT_REV_ID: 53e819bfd8ec6f6d85610677131edefa4207087f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2620.
A local
_memcmp-method has previously been used when comparing strings in order to avoid indirect recursions. Unless this issue is still present then we may usememory.memcmpinstead which would be preferred since the local_memcmpisn't vectorized.