[Docs] correct output, fix indent in Heterogeneous variadic arguments #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wah Loon Keng <kengzwl@gmail.com>
KenJones-Modular
approved these changes
May 22, 2024
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in a2c9820! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
May 23, 2024
…c arguments (#40435) [External] [Docs] correct output, fix indent in Heterogeneous variadic arguments The current [Heterogeneous variadic arguments](https://docs.modular.com/mojo/manual/functions#heterogeneous-variadic-arguments) (see screenshot) - last example has wrong output (`Bob0` should be `Bob`), and indentation of the example code is also off (had to edit after copying into Mojo playground) <img width="838" alt="Screenshot 2024-05-12 at 9 31 51 AM" src="https://github.com/modularml/mojo/assets/8209263/9ea82a34-9ac4-4414-b391-9d8b7f31357f"> Co-authored-by: Wah Loon Keng <kengzwl@gmail.com> Closes #2741 MODULAR_ORIG_COMMIT_REV_ID: c06231809a24351548c4967f66faf65d9204e859
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…c arguments (#40435) [External] [Docs] correct output, fix indent in Heterogeneous variadic arguments The current [Heterogeneous variadic arguments](https://docs.modular.com/mojo/manual/functions#heterogeneous-variadic-arguments) (see screenshot) - last example has wrong output (`Bob0` should be `Bob`), and indentation of the example code is also off (had to edit after copying into Mojo playground) <img width="838" alt="Screenshot 2024-05-12 at 9 31 51 AM" src="https://github.com/modularml/mojo/assets/8209263/9ea82a34-9ac4-4414-b391-9d8b7f31357f"> Co-authored-by: Wah Loon Keng <kengzwl@gmail.com> Closes modularml#2741 MODULAR_ORIG_COMMIT_REV_ID: c06231809a24351548c4967f66faf65d9204e859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Heterogeneous variadic arguments (see screenshot) - last example has wrong output (
Bob0should beBob), and indentation of the example code is also off (had to edit after copying into Mojo playground)