Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy options for PSR-7 Service #16539

Merged
merged 2 commits into from
May 20, 2024
Merged

Added proxy options for PSR-7 Service #16539

merged 2 commits into from
May 20, 2024

Conversation

MaticSulc
Copy link
Contributor

What does it do?

It uses the MODX proxy system settings for the PSR-7 service.

Why is it needed?

When behind a proxy, this allows search/listing of Extras.

How to test

Set all required proxy settings, open the Extras manager. If access to the Internet is only available via a proxy, it should work as expected.

Related issue(s)/PR(s)

Resolves #16538

@MaticSulc
Copy link
Contributor Author

Regarding the system setting proxy_auth_type, I have not found how to use NTLM authentication type - so I didn't include it in this PR.

@opengeek
Copy link
Member

Thank you for your contribution! Before your pull request can be reviewed, please sign the MODX Contributor License Agreement (CLA). This is to ensure MODX has your written permission to distribute projects containing your contributions under the appropriate license.

Please make sure the CLA has been signed for GitHub user(s): @MaticSulc

Once you've signed, please reply with a comment letting us know so we can verify.

@MaticSulc
Copy link
Contributor Author

Thank you for your contribution! Before your pull request can be reviewed, please sign the MODX Contributor License Agreement (CLA). This is to ensure MODX has your written permission to distribute projects containing your contributions under the appropriate license.

Please make sure the CLA has been signed for GitHub user(s): @MaticSulc

Once you've signed, please reply with a comment letting us know so we can verify.

Signed it! :)

@Ibochkarev Ibochkarev added the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label May 17, 2024
@opengeek opengeek merged commit 2adb4b1 into modxcms:3.x May 20, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy system setting ignored in MODX3
5 participants