-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance textarea tv type #16553
base: 3.x
Are you sure you want to change the base?
Enhance textarea tv type #16553
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16553 +/- ##
============================================
- Coverage 21.57% 21.55% -0.02%
Complexity 10577 10577
============================================
Files 561 561
Lines 31975 32003 +28
============================================
Hits 6898 6898
- Misses 25077 25105 +28 ☔ View full report in Codecov by Sentry. |
@smg6511 This does seem to function and it's a nice add. One note, however, upon creation, until you change the values set for the Grow or Resizable input options, Revo throws a warning about undefined keys but once you change the input values the first time, this resolves.
It shouldn't require changing of the values as many people may not want to or need to change the values. |
Adds new input options to control input height
Adds new utility function to evaluate boolean-type values, which ensures only set params are accessed; applies this function to the two vars in the textarea input opts config file that were throwing php warnings. Note that the new function will be applicable to other config files.
@jaygilmore Ok, got that covered. Thanks for taking a look. |
What does it do?
Adds new input options to control input height.
Why is it needed?
Currently this input type is restricted to its default size of 140px.
How to test
_build/templates/default
and rungrunt build
)Related issue(s)/PR(s)
Resolves #5512