select.lua: strip trailing zeros from FPS values #14144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if 3 decimal digits is too many here. |
guidocella
force-pushed
the
format-fps
branch
2 times, most recently
from
8d3a5cf
to
accfa2d
Compare
Show e.g. "30 fps" instead of "30.000 fps". Also switch to %.4f for consistency with pretty_print_double().
|
Download the artifacts for this pull request: |
|
Why? IMO look better than The former representation is commonly used for these frame rate values. |
|
I think the latter looks better and is consistent with |
|
Arguably when we are displaying values together in one table like output they should have the same precision. Although I doubt there are many cases where fps will differ in the same file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show e.g. "30 fps" instead of "30.000 fps".