-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options: reset some options between files by default #14151
Conversation
Download the artifacts for this pull request: |
This purely depends on the contents of the playlist in question. It's very often that all videos in the playlist come from closely-related sources. I don't want the crop and rotate settings to be reset for this reason. Switching to the next file and then switching it back also causes the settings to be reset. Also it makes no sense to reset ab loop points without also resetting |
4879430
to
966a267
Compare
I always wanted to reset rotate and crop to reset between files, it's hard to guess how common the use case you mentioned is. We can remove those and add ab-loop only if desired. Resetting ab-loop is also nice because it is not obvious how to add it to A tricky one is and IRC discussions: 2023-09-18 17:47:53 ChH guido: kasper93: I didn't realize how weird loop-file is, I've always only used it with yes/no. I thought resetting it means that if mpv gets started without it and then set to 'yes' at runtime, then resetting it would mean it goes to 'no' when going to the next file. |
Add ab-loop options to --reset-on-next-file's default value because you never want to preserve them between files. VLC and MPC-HC also reset them.
966a267
to
83d583e
Compare
I made this ab loop only which should be uncontroversial. |
Do we really need this change? Are we fixing anything? I can image |
That would be weird since episodes have different durations, but it's fine if the change is not worth it. |
Add some options to --reset-on-next-file's default value that you commonly don't want to keep between files. The catch is that if you specify options in the command line or mpv.conf --reset-on-next-file resets to those values, but the vast majority of uses for these options should be at runtime.