Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed outliner option out of sync with object name #28263

Closed
wants to merge 1 commit into from

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 3, 2024

With this PR, outliner's option label will keep in sync with its object name, e.g.:

sync.rename.mp4

Preview: https://raw.githack.com/ycw/three.js/editor-rename-object/editor/index.html

@Mugen87 Mugen87 added this to the r165 milestone May 3, 2024
@ycw
Copy link
Contributor Author

ycw commented May 3, 2024

dont' merge, i found that it doesn't honor undo/redo history :(

@ycw ycw force-pushed the editor-rename-object branch 2 times, most recently from a1821e0 to 7a57f09 Compare May 3, 2024 10:07
@ycw
Copy link
Contributor Author

ycw commented May 3, 2024

fixed :D

rename+history.mp4

@ycw ycw requested a review from Mugen87 May 3, 2024 10:34
@ycw
Copy link
Contributor Author

ycw commented May 3, 2024

closed for now... Reason: The PR suggested triggers another layout bugs in outliner:

bug.mp4

@ycw ycw closed this May 3, 2024
@Mugen87 Mugen87 modified the milestone: r165 May 3, 2024
@ycw ycw deleted the editor-rename-object branch May 3, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants