Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS API improvements #2308

Merged
merged 8 commits into from
Jun 1, 2024
Merged

TTS API improvements #2308

merged 8 commits into from
Jun 1, 2024

Conversation

blob42
Copy link
Contributor

@blob42 blob42 commented May 13, 2024

Description

Continuation of PR #2086

Improvements to the Coqui TTS API/backend.

  • tts coqui xtts_v2 not working without speaker_idx  #2073: Allow passing speaker_id to models
  • Add optional language parameter to TTS endpoint/schema
  • [ ] TTS Info endpoint: List available models, speakers and languages (will start new PR for this one)
  • update swagger documentation
  • define tts models with config files
  • updated docs

Notes for Reviewers

The original PR got closed when I force deleted by error the branch while merging

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 5ee80e3
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/665b53875c43e60008090fa5
😎 Deploy Preview https://deploy-preview-2308--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blob42
Copy link
Contributor Author

blob42 commented May 13, 2024

Sorry I deleted the branch by error and it closed the PR. If you reopen the previous PR I can force push again there. I had a difficult merge due to the refactor done on backend config.

@blob42 blob42 force-pushed the tts_api branch 9 times, most recently from 1302179 to 302daaa Compare May 13, 2024 08:20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not setup git to ignore the end of line space, I am using unix end of line style.

@blob42
Copy link
Contributor Author

blob42 commented May 31, 2024

@mudler let me know when this PR is planned for review/merge so that I can fix the conflicts at once.

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here, thanks @blob42 - just a matter of getting green lights from CI from my side

@blob42 blob42 force-pushed the tts_api branch 2 times, most recently from d40e2f0 to 60c6570 Compare June 1, 2024 11:39
Signed-off-by: blob42 <contact@blob42.xyz>
Signed-off-by: blob42 <contact@blob42.xyz>
Signed-off-by: blob42 <contact@blob42.xyz>
Signed-off-by: blob42 <contact@blob42.xyz>
Signed-off-by: blob42 <contact@blob42.xyz>
- consolidate TTS options under `tts` config entry

Signed-off-by: blob42 <contact@blob42.xyz>
Signed-off-by: blob42 <contact@blob42.xyz>
@mudler mudler enabled auto-merge (squash) June 1, 2024 18:03
@mudler mudler merged commit b99182c into mudler:master Jun 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants