Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][examples] Improvements to Material UI UMD build removal #42284

Merged
merged 10 commits into from
May 29, 2024
Merged

[docs][examples] Improvements to Material UI UMD build removal #42284

merged 10 commits into from
May 29, 2024

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented May 18, 2024 •
edited by oliviertassinari

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation examples Relating to /examples labels May 18, 2024
@mui-bot
Copy link

mui-bot commented May 18, 2024 •
edited

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c9ae9c8

@ZeeshanTamboli ZeeshanTamboli changed the title [docs][examples] Improvements to removal of UMD build changes [docs][examples] Improvements to UMD build removal May 18, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][examples] Improvements to UMD build removal [docs][examples] Improvements to Material UI UMD build removal May 18, 2024
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review May 18, 2024 07:56
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request May 18, 2024
Merged
1 task
oliviertassinari
oliviertassinari approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the polish.

oliviertassinari
oliviertassinari reviewed May 22, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, remove my approval, we shouldn't depend on me.

oliviertassinari

This comment was marked as resolved.

Sign in to view

@oliviertassinari oliviertassinari self-requested a review May 22, 2024 00:08
@oliviertassinari oliviertassinari removed their request for review May 22, 2024 00:08
@oliviertassinari
Copy link
Member

oliviertassinari commented May 22, 2024 •
edited

Oh damn!

SCR-20240522-ctgz

https://unpkg.com/browse/@mui/material@5.15.18/umd/

to compare with https://packagephobia.com/result?p=%40mui%2Fmaterial

SCR-20240522-ctzt

10% smaller or 25% smaller, depending on how you look at this. We can use this to sell the change; no missed opportunities to do marketing 😄.

@oliviertassinari
clarty
a7afb39 
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
DiegoAndai
DiegoAndai approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZeeshanTamboli

@ZeeshanTamboli ZeeshanTamboli merged commit 2af7a0f into mui:next May 29, 2024
19 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the improve-remove-umd-build-changes branch May 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation examples Relating to /examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZeeshanTamboli @mui-bot @oliviertassinari @DiegoAndai