-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor GetFullText() #2587
Open
certuna
wants to merge
11
commits into
navidrome:master
Choose a base branch
from
certuna:refactor-fulltext
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor GetFullText() #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download the artifacts for this pull request: |
This was referenced Nov 7, 2023
There was a reason for that, I just don't remember what... I'll have to take a careful look at this before merging. |
temporary to resolve conflict
redo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the
mf.FullText
anda.FullText
fields are populated inside the sqlPut()
functions in the artist/mediafile repository code instead of where all other mf.* and a.* fields are populated.Also, the
getFullText()
function used inPut()
is not used fora.FullText
inmodel/media_file.go
This refactoring:
utils/sanitize_strings.go
mf.FullText
inscanner/mapping.go
along with the rest of the mf.* fieldsa.FullText
inalbum.go
along with the rest along with the rest of the a.* fieldsa.FullText
inmodel/media_file.go