Fix image stuttering. #3035
Merged
Fix image stuttering. #3035
+125
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweymouth
reviewed
May 19, 2024
| @@ -64,8 +64,9 @@ func (api *Router) GetCoverArt(w http.ResponseWriter, r *http.Request) (*respons | |||
| p := req.Params(r) | |||
| id, _ := p.String("id") | |||
| size := p.IntOr("size", 0) | |||
| square := p.BoolOr("square", false) | |||
There was a problem hiding this comment.
"square" is not a parameter for Subsonic or OpenSubsonic getCoverArt. Probably can just pass false directly
There was a problem hiding this comment.
Oh... looks like the web UI uses the subsonic api to fetch images?
There was a problem hiding this comment.
Yeah, I proposed this. This is a quick "hack" to fix an issue in the (current) WebUI.
I don't mean to document and/or propose this to OpenSubsonic, it is just an internal thing.
For the new UI we will introduce a proper native artwork endpoint, and this parameter will be removed from the getCoverArt endpoint.
deluan
requested changes
May 19, 2024
|
Download the artifacts for this pull request: |
deluan
requested changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AlbumGrid shaking when a non-square album cover is rendered.