migrate to neo4j-graphql-java #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jexp
reviewed
Nov 11, 2020
| init { | ||
| log = provider.getLog(GraphQLResource::class.java) | ||
| } | ||
| @Path("/{db}") |
There was a problem hiding this comment.
we need the fallback for the default db (aka neo4j)
There was a problem hiding this comment.
is this really necessary? since we will have conflicts like:
GET /idl
is idl the database name or is it the path for managing the idl resource on the default neo4j database?
There was a problem hiding this comment.
you're right, I was just trying to be backwards compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code migration completed.
open tasks: