Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Graph Scale Buttons instead of Dropdown #3311

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kenzo44
Copy link
Contributor

@kenzo44 kenzo44 commented Apr 28, 2024

An alternative solution to #3306 - instead of having text overlayed on the graph, added buttons to switch between scales.

Users can tap on buttons to quickly switch between graph scales instead of doing it with 3 actions. This will also make the dropdown exclusively for graph data management.

Todo:

  • Remove graph scale from the dropdown menu
  • Remove long tap on graph to switch between graph scales

@kenzo44 kenzo44 marked this pull request as draft April 28, 2024 00:31
Copy link

sonarcloud bot commented Apr 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vanelsberg
Copy link
Contributor

Nice...

Q: Looks like this PR was based on dev + PR#3306?
Merging PR#3311 on top of PR#3306 results in a merge conflict... 🤔

@kenzo44 kenzo44 marked this pull request as ready for review April 30, 2024 03:12
@vanelsberg
Copy link
Contributor

Merge with current dev. Works without issues. Nice!

@vanelsberg vanelsberg mentioned this pull request May 12, 2024
@kenzo44 kenzo44 marked this pull request as draft May 15, 2024 20:42
@Philoul
Copy link
Contributor

Philoul commented May 24, 2024

Final proposal (clean PR) done here #3347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants