Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove xwaretech domains #8329

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joecool1029
Copy link

These were mistakenly added as disposable email domains.

Change Summary

Removes the xwaretech.* domains from nocodb/src/helpers/isDisposableEmail.ts .

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

just 3 lines containing xwaretech removed from isDisposableEmail.ts.

Additional information / screenshots (optional)

Many years ago these pointed to mailinator, it's been my slow battle to remove references to them on github since I use them for my consulting company.

These were mistakenly added as disposable email domains.

Signed-off-by: Joe Kappus <joe@wt.gd>
@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: . Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dstala dstala added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Apr 24, 2024
@joecool1029
Copy link
Author

@dstala is there an issue with removing these?

@dstala
Copy link
Member

dstala commented May 6, 2024

@joecool1029 we do not custom manage this list. request you to get it changed here
https://github.com/amieiro/disposable-email-domains/blob/master/allowDomains.json

@dstala dstala closed this May 6, 2024
@joecool1029
Copy link
Author

joecool1029 commented May 6, 2024

@dstala You linked their project's allowDomains list, which is not a block list.

My domains are in there because they are not to be included as a disposable domain.

Any domains in that list should not be included as a disposable email, it is your project's mistake and your misunderstanding.

EDIT: https://github.com/amieiro/disposable-email-domains/blob/master/README.md < their README on the topic.

@dstala dstala reopened this May 6, 2024
@dstala dstala requested a review from pranavxc May 16, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons.
Projects
Status: 🏌️ Open
Development

Successfully merging this pull request may close these issues.

None yet

4 participants