New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove xwaretech domains #8329
base: develop
Are you sure you want to change the base?
Conversation
These were mistakenly added as disposable email domains. Signed-off-by: Joe Kappus <joe@wt.gd>
Important Auto Review SkippedAuto reviews are limited to the following labels: . Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@dstala is there an issue with removing these? |
@joecool1029 we do not custom manage this list. request you to get it changed here |
@dstala You linked their project's allowDomains list, which is not a block list. My domains are in there because they are not to be included as a disposable domain. Any domains in that list should not be included as a disposable email, it is your project's mistake and your misunderstanding. EDIT: https://github.com/amieiro/disposable-email-domains/blob/master/README.md < their README on the topic. |
These were mistakenly added as disposable email domains.
Change Summary
Removes the xwaretech.* domains from nocodb/src/helpers/isDisposableEmail.ts .
Change type
Test/ Verification
just 3 lines containing xwaretech removed from isDisposableEmail.ts.
Additional information / screenshots (optional)
Many years ago these pointed to mailinator, it's been my slow battle to remove references to them on github since I use them for my consulting company.