Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove calendar top bar #8379

Merged
merged 28 commits into from May 14, 2024
Merged

feat: remove calendar top bar #8379

merged 28 commits into from May 14, 2024

Conversation

DarkPhoenix2704
Copy link
Member

@DarkPhoenix2704 DarkPhoenix2704 commented May 3, 2024 •
edited

Change Summary

Provide summary of changes with issue number if any.

Update the calendar style.
Removed the Calendar topbar and moved them to toolbar and side menu
Updated posthog events
Updated tests to new ui

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@DarkPhoenix2704 DarkPhoenix2704 self-assigned this May 3, 2024
@coderabbitai coderabbitai

This comment was marked as outdated.

Sign in to view
coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited

Uffizzi Preview deployment-51183 was deleted.

@o1lab o1lab force-pushed the nc-feat/cal-toolbar branch 4 times, most recently from 4c228fb to 9fa283d Compare May 3, 2024 08:17
coderabbitai[bot]

This comment was marked as spam.

Sign in to view

@o1lab o1lab force-pushed the nc-feat/cal-toolbar branch 2 times, most recently from 8da89b2 to bb07754 Compare May 3, 2024 09:53
coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

@o1lab o1lab force-pushed the nc-feat/cal-toolbar branch 4 times, most recently from bb3e8d0 to 2a93562 Compare May 4, 2024 07:12
coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

@o1lab o1lab force-pushed the nc-feat/cal-toolbar branch 2 times, most recently from a9e0b2f to 2de3e3b Compare May 4, 2024 13:14
coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

@o1lab o1lab force-pushed the nc-feat/cal-toolbar branch 2 times, most recently from 2b13368 to fde2e23 Compare May 6, 2024 07:20
coderabbitai[bot]
coderabbitai bot reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2e99344 and fde2e23.
Files ignored due to path filters (1)
  • packages/nc-gui/lang/en.json is excluded by !**/*.json
Files selected for processing (33)
  • packages/nc-gui/assets/style.scss (1 hunks)
  • packages/nc-gui/components/nc/DateWeekSelector.vue (8 hunks)
  • packages/nc-gui/components/nc/MonthYearSelector.vue (5 hunks)
  • packages/nc-gui/components/smartsheet/Toolbar.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (4 hunks)
  • packages/nc-gui/components/smartsheet/calendar/MonthView.vue (7 hunks)
  • packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (6 hunks)
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (7 hunks)
  • packages/nc-gui/components/smartsheet/calendar/YearView.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/calendar/index.vue (5 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue (3 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/SearchData.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue (3 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue (3 hunks)
  • packages/nc-gui/composables/useCalendarViewStore.ts (13 hunks)
  • packages/nc-gui/composables/useViewColumns.ts (1 hunks)
  • tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts (2 hunks)
  • tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts (1 hunks)
  • tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts (1 hunks)
  • tests/playwright/pages/Dashboard/Calendar/index.ts (4 hunks)
  • tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts (1 hunks)
  • tests/playwright/pages/Dashboard/common/Toolbar/index.ts (5 hunks)
  • tests/playwright/tests/db/views/viewCalendar.spec.ts (6 hunks)
Files skipped from review as they are similar to previous changes (32)
  • packages/nc-gui/assets/style.scss
  • packages/nc-gui/components/nc/DateWeekSelector.vue
  • packages/nc-gui/components/nc/MonthYearSelector.vue
  • packages/nc-gui/components/smartsheet/Toolbar.vue
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue
  • packages/nc-gui/components/smartsheet/calendar/MonthView.vue
  • packages/nc-gui/components/smartsheet/calendar/SideMenu.vue
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue
  • packages/nc-gui/components/smartsheet/calendar/YearView.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue
  • packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue
  • packages/nc-gui/components/smartsheet/toolbar/SearchData.vue
  • packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue
  • packages/nc-gui/composables/useCalendarViewStore.ts
  • packages/nc-gui/composables/useViewColumns.ts
  • tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts
  • tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts
  • tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts
  • tests/playwright/pages/Dashboard/Calendar/index.ts
  • tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts
  • tests/playwright/pages/Dashboard/common/Toolbar/index.ts
  • tests/playwright/tests/db/views/viewCalendar.spec.ts
Additional comments not posted (1)
packages/nc-gui/components/smartsheet/calendar/index.vue (1)

22-22: Ensure proper error handling for external calls in $e.

@DarkPhoenix2704
fix: update styles
3a607c8
@DarkPhoenix2704
fix: posthog telementry
f52fccf
@DarkPhoenix2704
fix: calendar tests
4a7d7c5
@DarkPhoenix2704
fix: updates ui
acc77c3
@DarkPhoenix2704
test: reorder options
b2d5e0c
@DarkPhoenix2704
fix: month view - use local time with timezone
9c77d23
@DarkPhoenix2704
fix: update styles and move components fix: tests
5cef266
@DarkPhoenix2704
fix: update styles and move components
c971f32
@DarkPhoenix2704
fix: update styles
1ab258d
@DarkPhoenix2704
test: fix tests
35d2909
@DarkPhoenix2704
fix: update toolbar styles
4be3519
@DarkPhoenix2704
fix: failing tests
785438c
@DarkPhoenix2704
fix: cmd f search shortcut
de621bb
@DarkPhoenix2704
fix: change side menu sizes
e5761bd
@DarkPhoenix2704
fix: calendar test corrections
197b3da
@DarkPhoenix2704
fix(nc-gui): update size logic
266f073
@DarkPhoenix2704
fix(nc-gui): update styles
773222b
@DarkPhoenix2704
fix(nc-gui): update some more styles
3666c98
@DarkPhoenix2704
fix(nc-gui): update toolbar styles
8720297
@DarkPhoenix2704
fix(nc-gui): update select component
dcee461
@DarkPhoenix2704
fix: update styles
b253d22
@DarkPhoenix2704
fix: calendar test
733f101
@DarkPhoenix2704
fix: ux changes
b7293ef
@DarkPhoenix2704
fix: final changes
03280aa
@DarkPhoenix2704
fix: calendar tests
5ffc28c
coderabbitai[bot]
coderabbitai bot reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (2)
packages/nc-gui/components/smartsheet/calendar/index.vue (2)

5-5: Consider adding a comment to explain the purpose of the $e event trigger for better maintainability.

Adding a brief comment can help other developers understand the purpose of this event trigger.

117-117: Please ensure that ARIA roles and responsive design features are implemented in the calendar wrapper to enhance accessibility and user experience.

Implementing ARIA roles and ensuring responsive design will improve accessibility and usability.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 98c115e and 5ffc28c.
Files ignored due to path filters (1)
  • packages/nc-gui/lang/en.json is excluded by !**/*.json
Files selected for processing (48)
  • packages/nc-gui/assets/style.scss (2 hunks)
  • packages/nc-gui/components/cmd-k/index.vue (1 hunks)
  • packages/nc-gui/components/cmd-l/index.vue (1 hunks)
  • packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue (1 hunks)
  • packages/nc-gui/components/dashboard/TreeView/ViewsNode.vue (1 hunks)
  • packages/nc-gui/components/dlg/ViewCreate.vue (8 hunks)
  • packages/nc-gui/components/dlg/ViewDelete.vue (1 hunks)
  • packages/nc-gui/components/nc/DateWeekSelector.vue (10 hunks)
  • packages/nc-gui/components/nc/Divider.vue (1 hunks)
  • packages/nc-gui/components/nc/Modal.vue (1 hunks)
  • packages/nc-gui/components/nc/MonthYearSelector.vue (4 hunks)
  • packages/nc-gui/components/nc/Select.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/Toolbar.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue (4 hunks)
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue (5 hunks)
  • packages/nc-gui/components/smartsheet/calendar/MonthView.vue (10 hunks)
  • packages/nc-gui/components/smartsheet/calendar/SideMenu.vue (7 hunks)
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue (3 hunks)
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue (9 hunks)
  • packages/nc-gui/components/smartsheet/calendar/YearView.vue (4 hunks)
  • packages/nc-gui/components/smartsheet/calendar/index.vue (4 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue (4 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/SearchData.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue (3 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue (3 hunks)
  • packages/nc-gui/components/smartsheet/topbar/SelectMode.vue (2 hunks)
  • packages/nc-gui/components/tabs/Smartsheet.vue (1 hunks)
  • packages/nc-gui/composables/useCalendarViewStore.ts (12 hunks)
  • packages/nc-gui/composables/useViewColumns.ts (1 hunks)
  • packages/nc-gui/utils/iconUtils.ts (3 hunks)
  • packages/nc-gui/windi.config.ts (1 hunks)
  • tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts (2 hunks)
  • tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts (3 hunks)
  • tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts (1 hunks)
  • tests/playwright/pages/Dashboard/Calendar/index.ts (4 hunks)
  • tests/playwright/pages/Dashboard/ViewSidebar/index.ts (1 hunks)
  • tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts (1 hunks)
  • tests/playwright/pages/Dashboard/common/Toolbar/index.ts (5 hunks)
  • tests/playwright/tests/db/general/toolbarOperations.spec.ts (1 hunks)
  • tests/playwright/tests/db/views/viewCalendar.spec.ts (8 hunks)
Files skipped from review as they are similar to previous changes (47)
  • packages/nc-gui/assets/style.scss
  • packages/nc-gui/components/cmd-k/index.vue
  • packages/nc-gui/components/cmd-l/index.vue
  • packages/nc-gui/components/dashboard/TreeView/CreateViewBtn.vue
  • packages/nc-gui/components/dashboard/TreeView/ViewsNode.vue
  • packages/nc-gui/components/dlg/ViewCreate.vue
  • packages/nc-gui/components/dlg/ViewDelete.vue
  • packages/nc-gui/components/nc/DateWeekSelector.vue
  • packages/nc-gui/components/nc/Divider.vue
  • packages/nc-gui/components/nc/Modal.vue
  • packages/nc-gui/components/nc/MonthYearSelector.vue
  • packages/nc-gui/components/nc/Select.vue
  • packages/nc-gui/components/smartsheet/Toolbar.vue
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateField.vue
  • packages/nc-gui/components/smartsheet/calendar/DayView/DateTimeField.vue
  • packages/nc-gui/components/smartsheet/calendar/MonthView.vue
  • packages/nc-gui/components/smartsheet/calendar/SideMenu.vue
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateField.vue
  • packages/nc-gui/components/smartsheet/calendar/WeekView/DateTimeField.vue
  • packages/nc-gui/components/smartsheet/calendar/YearView.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/ActiveView.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Header.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Mode.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Range.vue
  • packages/nc-gui/components/smartsheet/toolbar/Calendar/Today.vue
  • packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/RowHeight.vue
  • packages/nc-gui/components/smartsheet/toolbar/SearchData.vue
  • packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue
  • packages/nc-gui/components/smartsheet/toolbar/StackedBy.vue
  • packages/nc-gui/components/smartsheet/topbar/SelectMode.vue
  • packages/nc-gui/components/tabs/Smartsheet.vue
  • packages/nc-gui/composables/useCalendarViewStore.ts
  • packages/nc-gui/composables/useViewColumns.ts
  • packages/nc-gui/utils/iconUtils.ts
  • packages/nc-gui/windi.config.ts
  • tests/playwright/pages/Dashboard/Calendar/CalendarSideMenu.ts
  • tests/playwright/pages/Dashboard/Calendar/CalendarWeekDateTime.ts
  • tests/playwright/pages/Dashboard/Calendar/CalendarYear.ts
  • tests/playwright/pages/Dashboard/Calendar/index.ts
  • tests/playwright/pages/Dashboard/ViewSidebar/index.ts
  • tests/playwright/pages/Dashboard/common/Toolbar/CalendarViewMode.ts
  • tests/playwright/pages/Dashboard/common/Toolbar/index.ts
  • tests/playwright/tests/db/general/toolbarOperations.spec.ts
  • tests/playwright/tests/db/views/viewCalendar.spec.ts

@DarkPhoenix2704 DarkPhoenix2704 merged commit fb67caf into develop May 14, 2024
19 of 23 checks passed
@DarkPhoenix2704 DarkPhoenix2704 deleted the nc-feat/cal-toolbar branch May 14, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@dstala dstala dstala approved these changes

Assignees

@DarkPhoenix2704 DarkPhoenix2704

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DarkPhoenix2704 @o1lab @dstala