fix: filter datetime (sqlite / mysql)

[cangku]

Change Summary

• fix datatime can't filter data, where is today, datetime is now, use date without timezone no error, has timezone will can't filter. under other conditions, it's necessary to consider whether the time point is the beginning or the end of a day.
  
• fix mysql can't use datetime filter.

Change type

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates to the nocodb project primarily involve enhancements in handling date and time conditions within the database queries. Modifications were made to ensure that time comparisons are handled in UTC and that the date boundaries are more precisely defined. Additionally, the conditions now accommodate specific UI types, enhancing the flexibility and accuracy of UI-driven query operations.

Changes

File Path	Change Summary
.../src/db/conditionV2.ts	Updated parseConditionV2 to use dayjs.utc(), refined time comparisons with endOf('d') and startOf('d'), and included UI type-specific conditions.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 67dbe7c and e18829d.

Files selected for processing (1)

• packages/nocodb/src/db/conditionV2.ts (4 hunks)

Additional comments not posted (2)

packages/nocodb/src/db/conditionV2.ts (2)

600-605: Ensure consistent handling of datetime values.

The use of dayjs().utc() for the now variable and the adjustment for the first day of the month using dayjs(now).utc().date(1) are appropriate for handling timezone issues effectively. This change aligns with the PR's objective to fix datetime filtering issues.

---

671-684: Refine datetime comparisons to consider the start or end of the day.

The logic to use endOf('d') for operations like 'gt', 'ge', 'gte' and startOf('d') for 'eq', 'neq', 'lt', 'lte' ensures that the datetime comparisons are accurate down to the day level. This is crucial for functionality that depends on the precision of datetime values, such as filters that specify a day without a time component.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (1)

packages/nocodb/src/db/conditionV2.ts (1)

Line range hint 1-1000: Review the overall structure and logic of the parseConditionV2 function.

The parseConditionV2 function is quite large and handles multiple responsibilities, which could be split into smaller, more manageable functions. This would improve readability and maintainability. Consider refactoring to separate the logic for different types of filters and their handling into distinct functions or modules.