test(web): Migrate Cypress tests to Playwright #5555

tatarco · 2024-05-13T12:25:45Z

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

linear · 2024-05-13T12:25:48Z

NV-3650 Migrate the rest Cypress tests to the Playwright

netlify · 2024-05-13T12:26:00Z

✅ Deploy Preview for dev-web-novu ready!

Name	Link
🔨 Latest commit	`dcc6568`
🔍 Latest deploy log	https://app.netlify.com/sites/dev-web-novu/deploys/66582fb8b28a48000816fc57
😎 Deploy Preview	https://deploy-preview-5555--dev-web-novu.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-05-13T12:26:01Z

✅ Deploy Preview for novu-design ready!

Name	Link
🔨 Latest commit	`dcc6568`
🔍 Latest deploy log	https://app.netlify.com/sites/novu-design/deploys/66582fb81fa4560008b12dc0
😎 Deploy Preview	https://deploy-preview-5555--novu-design.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

scopsy · 2024-05-22T07:10:48Z

.github/workflows/test.yml

-  test_widget:
-    name: Test Widget Cypress
-    needs: [get-affected]
-    uses: ./.github/workflows/reusable-widget-e2e.yml
-    with:
-      ee: true
-    if: contains(github.event.pull_request.labels.*.name, 'run-e2e')
-#    if: ${{ contains(fromJson(needs.get-affected.outputs.test-cypress), '@novu/widget') || contains(fromJson(needs.get-affected.outputs.test-unit), '@novu/notification-center') || contains(fromJson(needs.get-affected.outputs.test-unit), '@novu/ws') }}
-    secrets: inherit


question: ‏How are we testing this functionality now?

@tatarco Widgets should be probably kept here, we migrated just the web tests

@scopsy please contact @SokratisVidros ,it was a joint decision to cut off cypress as it brings no assurance ATM, push working tests now and move over to fix the rest including the widget but to start by ripping off cypress

.github/workflows/reusable-web-e2e.yml

.github/workflows/reusable-widget-e2e.yml

LetItRock · 2024-05-22T07:49:13Z

.github/workflows/scheduled_e2e.yml

-  test_widget:
-    name: Test Widget Cypress
-    uses: ./.github/workflows/reusable-widget-e2e.yml
-    with:
-      ee: true
-    secrets: inherit


☑ chore: the widget tests should run in this pipeline

LetItRock · 2024-05-22T07:53:20Z

.vscode/launch.json

-    {
-      "name": "Cypress open - web",
-      "request": "launch",
-      "runtimeArgs": [
-        "run-script",
-        "cypress:open"
-      ],
-      "runtimeExecutable": "npm",
-      "cwd": "${workspaceFolder}/apps/web",
-      "skipFiles": [
-        "<node_internals>/**"
-      ],
-      "type": "pwa-node"
-    },
-    {
-      "name": "Cypress open - widget",
-      "request": "launch",
-      "runtimeArgs": [
-        "run-script",
-        "cypress:open"
-      ],
-      "runtimeExecutable": "npm",
-      "cwd": "${workspaceFolder}/apps/widget",
-      "skipFiles": [
-        "<node_internals>/**"
-      ],
-      "type": "pwa-node"


❓ question: is there any reason to remove this?

removing all cypress, why should it stay?

LetItRock · 2024-05-22T07:55:24Z

apps/web/.env

@@ -12,7 +12,7 @@ REACT_APP_SEGMENT_KEY=
 REACT_APP_SENTRY_DSN=
 REACT_APP_BLUEPRINTS_API_URL=
 REACT_APP_MAIL_SERVER_DOMAIN=
-REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID=
+REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID=some_fake_id


☑ chore: we need to find another way to set this fake LD key, I'm worried that this env would be user during the docker image field and might build the web app and include this key

apps/web/panda.config.ts

apps/web/tests/activity-graph.spec.ts

apps/web/tests/page-models/authLoginPage.ts

libs/shared-web/src/hooks/useFeatureFlags.ts

rifont

Let's gooo! LGTM 🚢 it

denis-kralj-novu · 2024-05-27T22:34:15Z

.github/workflows/reusable-web-e2e.yml

@@ -93,7 +92,7 @@ jobs:
          REACT_APP_API_URL: http://127.0.0.1:1336
          REACT_APP_WS_URL: http://127.0.0.1:1340
          REACT_APP_WEBHOOK_URL: http://127.0.0.1:1341
-          REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID: ${{ secrets.TEST_LAUNCH_DARKLY_CLIENT_SIDE_ID }}
+          REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID: some_fake_id


❓ question: ‏ should this still be hardcoded?

denis-kralj-novu · 2024-05-27T22:34:50Z

.github/actions/setup-project/action.yml

@@ -47,22 +43,6 @@ runs:
      with:
        mongodb-version: 4.2.8



❓ question: ‏ Is this still OK to remove given that we still have cypress for the widget, or is this exclusive to for the web tests?

denis-kralj-novu · 2024-05-27T22:36:45Z

.github/workflows/reusable-web-e2e.yml

      - name: Playwright Install
        working-directory: apps/web
        run: pnpm playwright:install

      - name: Run Playwright tests
        working-directory: apps/web
+        env:
+          REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID: some_fake_id


❓ question: ‏ Same as above, should this stay hardcoded here like this?

This can be safely removed - its a leftover from some experiment I tried before.

denis-kralj-novu · 2024-05-27T22:39:10Z

apps/api/src/.env.test

@@ -2,7 +2,7 @@ GOOGLE_OAUTH_CLIENT_ID=11
 GOOGLE_OAUTH_CLIENT_SECRET=11
 GOOGLE_OAUTH_REDIRECT=http://127.0.0.1:3000/v1/auth/google/callback
 STORE_ENCRYPTION_KEY="<ENCRYPTION_KEY_MUST_BE_32_LONG>"
-BLUEPRINT_CREATOR=645b648b36dd6d25f8650d37
+BLUEPRINT_CREATOR=66507de8e76834a745c98f93


❓ question: ‏ I don't know what this is but am curious why it changed...

We use the staging API as a template data source. The id changed as staging env was replaced by dev.

denis-kralj-novu · 2024-05-27T22:44:10Z

apps/web/playwright.config.ts

-  /* Opt out of parallel tests on CI. */
-  workers: process.env.CI ? 4 : undefined,
+  retries: 2,
+  /* Use 4 workers in CI, 50% of CPU count in local */


🤓 nitpick (non-blocking): ‏ comment unaligned with actual config, should be removed altogether

denis-kralj-novu · 2024-05-28T09:41:33Z

apps/web/src/components/layout/components/EnsureOnboardingComplete.tsx

@@ -6,9 +6,9 @@ import { useBlueprint } from '../../../hooks/index';
 export function EnsureOnboardingComplete({ children }: any) {
  useBlueprint();
  const location = useLocation();
-  const { claims } = useAuth();
+  const { currentOrganization, environmentId } = useAuth();


⚠ issue: ‏ This doesn't build for me locally:

TS2339: Property 'environmentId' does not exist on type '{ inPublicRoute: boolean; inPrivateRoute: boolean; isLoading: boolean; currentUser: { organizationId: string; environmentId: string; _id: string; firstName?: string | undefined; lastName?: string | undefined; ... 7 more ...; hasPassword: boolean; }; ... 5 more ...; claims: IJwtClaims; }'. 7 | useBlueprint(); 8 | const location = useLocation(); > 9 | const { currentOrganization, environmentId } = useAuth(); | ^^^^^^^^^^^^^ 10 | 11 | if ((!currentOrganization || !environmentId) && location.pathname !== ROUTES.AUTH_APPLICATION) { 12 | return <Navigate to={ROUTES.AUTH_APPLICATION} replace />; ELIFECYCLE Command failed with exit code 1.```

Should be fixed now.

github-actions bot added the @novu/web label May 13, 2024

tatarco force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch 2 times, most recently from c5071ed to 3cb6086 Compare May 19, 2024 16:12

SokratisVidros changed the title ~~nv-3650-migrate-the-rest-cypress-tests-to-the-playwright~~ chore(root): nv-3650-migrate-the-rest-cypress-tests-to-the-playwright May 21, 2024

tatarco force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch from 997d62a to b11b151 Compare May 22, 2024 04:31

github-actions bot added @novu/notification-center @novu/notification-center-vue CI/CD scripts @novu/design-system labels May 22, 2024

tatarco marked this pull request as ready for review May 22, 2024 06:59

tatarco requested review from a team as code owners May 22, 2024 07:00

tatarco requested review from scopsy and AliaksandrRyzhou and removed request for a team May 22, 2024 07:00

scopsy reviewed May 22, 2024

View reviewed changes

LetItRock reviewed May 22, 2024

View reviewed changes

tatarco force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch from ecaa0c2 to 5307f32 Compare May 22, 2024 10:27

github-actions bot added the @novu/worker label May 22, 2024

tatarco force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch from 74bdff7 to cd1ae13 Compare May 22, 2024 11:28

github-actions bot removed the @novu/worker label May 22, 2024

rifont approved these changes May 24, 2024

View reviewed changes

github-actions bot added @novu/shared @novu/novui and removed @novu/shared @novu/novui labels May 24, 2024

github-actions bot added @novu/shared @novu/novui labels May 27, 2024

SokratisVidros force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch 2 times, most recently from 741f41b to e3656a5 Compare May 27, 2024 22:13

SokratisVidros temporarily deployed to Linting May 27, 2024 22:13 — with GitHub Actions Inactive

github-actions bot removed @novu/shared @novu/novui labels May 27, 2024

SokratisVidros force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch from e3656a5 to 240dcc5 Compare May 27, 2024 22:30

SokratisVidros temporarily deployed to Linting May 27, 2024 22:30 — with GitHub Actions Inactive

denis-kralj-novu reviewed May 27, 2024

View reviewed changes

LetItRock temporarily deployed to Linting May 28, 2024 01:36 — with GitHub Actions Inactive

LetItRock temporarily deployed to Linting May 28, 2024 07:15 — with GitHub Actions Inactive

SokratisVidros temporarily deployed to Linting May 28, 2024 09:00 — with GitHub Actions Inactive

denis-kralj-novu reviewed May 28, 2024

View reviewed changes

LetItRock temporarily deployed to Linting May 28, 2024 12:47 — with GitHub Actions Inactive

LetItRock had a problem deploying to Linting May 28, 2024 12:47 — with GitHub Actions Failure

SokratisVidros force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch from ab0a939 to 405d328 Compare May 30, 2024 07:42

chore(web): Migrate cypress web e2e suite to playwright

dcc6568

SokratisVidros force-pushed the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch from 405d328 to dcc6568 Compare May 30, 2024 07:50

SokratisVidros had a problem deploying to Linting May 30, 2024 07:50 — with GitHub Actions Failure

SokratisVidros temporarily deployed to Linting May 30, 2024 07:50 — with GitHub Actions Inactive

SokratisVidros had a problem deploying to Linting May 30, 2024 07:50 — with GitHub Actions Failure

SokratisVidros merged commit a9c9055 into next May 30, 2024
27 of 30 checks passed

SokratisVidros deleted the nv-3650-migrate-the-rest-cypress-tests-to-the-playwright branch May 30, 2024 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(web): Migrate Cypress tests to Playwright #5555

test(web): Migrate Cypress tests to Playwright #5555

tatarco commented May 13, 2024

linear bot commented May 13, 2024

netlify bot commented May 13, 2024 •

edited

netlify bot commented May 13, 2024 •

edited

scopsy May 22, 2024

ChmaraX May 22, 2024

tatarco May 22, 2024

LetItRock May 22, 2024

LetItRock May 22, 2024

tatarco May 22, 2024

LetItRock May 22, 2024

rifont left a comment

denis-kralj-novu May 27, 2024 •

edited

denis-kralj-novu May 27, 2024 •

edited

denis-kralj-novu May 27, 2024 •

edited

ChmaraX May 28, 2024

denis-kralj-novu May 27, 2024 •

edited

SokratisVidros May 30, 2024

denis-kralj-novu May 27, 2024 •

edited

denis-kralj-novu May 28, 2024

SokratisVidros May 30, 2024

test(web): Migrate Cypress tests to Playwright #5555

test(web): Migrate Cypress tests to Playwright #5555

Conversation

tatarco commented May 13, 2024

What changed? Why was the change needed?

Screenshots

Related enterprise PR

Special notes for your reviewer

linear bot commented May 13, 2024

netlify bot commented May 13, 2024 • edited

✅ Deploy Preview for dev-web-novu ready!

netlify bot commented May 13, 2024 • edited

✅ Deploy Preview for novu-design ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rifont left a comment

Choose a reason for hiding this comment

denis-kralj-novu May 27, 2024 • edited

Choose a reason for hiding this comment

denis-kralj-novu May 27, 2024 • edited

Choose a reason for hiding this comment

denis-kralj-novu May 27, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denis-kralj-novu May 27, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denis-kralj-novu May 27, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented May 13, 2024 •

edited

netlify bot commented May 13, 2024 •

edited

denis-kralj-novu May 27, 2024 •

edited

denis-kralj-novu May 27, 2024 •

edited

denis-kralj-novu May 27, 2024 •

edited

denis-kralj-novu May 27, 2024 •

edited

denis-kralj-novu May 27, 2024 •

edited