chore: Upgrade to pnpm 9, add conventional commit PR title linting

[rifont]

What changed? Why was the change needed?

• Upgrade to pnpm 9
  • replace all hardcoded versions of local packages with the workspace: directive, a requirement of PNPM v9. This has the benefit of ensuring we only depend on local packages, avoiding difficult-to-debug versioning mismatch issues.
• add conventional commit PR title linting
• update publish script to use nx release version, which updates the workspace: directive for packages to an actual version. These actual version changes should be reverted after publishing to NPM.

Screenshots

Add NX Version release to publish script (dry-run publish)
NB: we should look at upgrading to NX v19 to take advantage of their advanced release script capability.

Bad Conventional Commit types

Bad Conventional Commit Scope

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

[netlify]

❌ Deploy Preview for dev-web-novu failed. Why did it fail? →

Name	Link
🔨 Latest commit	64426d4
🔍 Latest deploy log	https://app.netlify.com/sites/dev-web-novu/deploys/664b1bfed8a5b80008229e55

[netlify]

✅ Deploy Preview for novu-design ready!

Name	Link
🔨 Latest commit	64426d4
🔍 Latest deploy log	https://app.netlify.com/sites/novu-design/deploys/664b1bfe0eee3b000818ba25
😎 Deploy Preview	https://deploy-preview-5598--novu-design.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rifont]

A friendly message added as a PR comment when the PR title is not conventional, alongside the actions needed to fix it.

[denis-kralj-novu]

This only affects the PR title? What about the squash commit message?

[rifont]

It targets the PR title which in turn is used as the squash commit message (the highlighted part of this screenshot). The PR description is not targeted by this action.

This won't target unsquashed commit messages that may have been pushed. That job still lives with the Git-husky pre-commit linting hook. We'll need to enforce squash-merges on Git to ensure all commits on the tree are conventionally titled. Let's have that discussion separately.

[denis-kralj-novu]

This only affects the PR title? What about the squash commit message?

[SokratisVidros]

@rifont excellent work!

Couple of notes:

1. If CM linting requires extra work at this point I'd address it in a separate PR so that this one remains focused on the PNPM upgrade. If it's ready, you can ignore the comment.
2. It would be good to move @novu/application-generic from packages to libs. It's an 100% internal package that adds value only to Nest.js apps. I think that we might end up using the workspace: protocol for all the private packages inside libs folder but not for the public NPM packages inside the packages folder. The reason is that we publish NPM packages, we need to get rid of that workspace: protocol in package.json.

Point 2 can be addressed in a follow up PR.

[SokratisVidros]

@rifont This is gold! It was one of the big blockers to bundling all our source code in a single file in Nest.

[rifont]

2. It would be good to move @novu/application-generic from packages to libs. It's an 100% internal package that adds value only to Nest.js apps. I think that we might end up using the workspace: protocol for all the private packages inside libs folder but not for the public NPM packages inside the packages folder. The reason is that we publish NPM packages, we need to get rid of that workspace: protocol in package.json.

@SokratisVidros I agree we should move @novu/application-generic to libs.

Regarding replacement of the workspace: to an actual version during the publishing process, the newly added nx release version part of the publish script handles this, so we can use workspace: protocol everywhere.