chore: address eslint errors #2182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheahjs
force-pushed
the
fix/typescript-types
branch
from
9f08783
to
0840b60
Compare
akx
reviewed
May 13, 2024
src/lib/apis/audio/index.ts
Outdated
| return null; | ||
| }); | ||
|
|
||
| if (error) { | ||
| throw error; | ||
| } | ||
|
|
||
| return res; | ||
| return res!; |
There was a problem hiding this comment.
Having to add !s like this smells like a bug...
There was a problem hiding this comment.
There's one tiny edge case that isn't fully covered, which is if the catch handles a falsey err, we don't re-throw that I can address.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
(That said, I'll have to reopen #2227 as a new PR anyway since you can't push to a closed PR, so that doesn't really affect this PR 😅. However, the type-related comments from that PR might apply to this one too.)
There was a problem hiding this comment.
See: #2233. It might be a good idea to start building types for the API on top of that, if it gets eventually merged?
cheahjs
force-pushed
the
fix/typescript-types
branch
from
8356bad
to
23b58a3
Compare
cheahjs
force-pushed
the
fix/typescript-types
branch
from
23b58a3
to
be89d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
devbranch.Description
npm run lint:frontendi18nextusage across the codebaseeslint-plugin-unused-importsto remove unused imports