fix: Auto Complete promql legend on select not getting proper value with { #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktx-vaidehi
force-pushed
the
fix/dashboard-promql-legend-issue
branch
4 times, most recently
from
c88eebb
to
5b076a3
Compare
ktx-abhay
force-pushed
the
fix/dashboard-promql-legend-issue
branch
from
5b076a3
to
d2accf6
Compare
ktx-vaidehi
force-pushed
the
fix/dashboard-promql-legend-issue
branch
from
d2accf6
to
11a816c
Compare
ktx-kirtan
approved these changes
May 20, 2024
ktx-abhay
force-pushed
the
fix/dashboard-promql-legend-issue
branch
4 times, most recently
from
b7fb4ed
to
b7ac470
Compare
WalkthroughThis change in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
931
to
944
| // Find the index of the last opening brace '{' | ||
| const openingBraceIndex = inputValue.lastIndexOf("{"); | ||
| const newValue = | ||
| inputValue.slice(0, openingBraceIndex + 1) + option + "}"; | ||
| return newValue; | ||
|
|
||
| //if { is not present add it at the start and than return | ||
| if (openingBraceIndex === -1) { | ||
| const newValue = | ||
| "{" + inputValue.slice(0, openingBraceIndex + 1) + option + "}"; | ||
| return newValue; | ||
| } else { | ||
| const newValue = | ||
| inputValue.slice(0, openingBraceIndex + 1) + option + "}"; | ||
| return newValue; | ||
| } |
There was a problem hiding this comment.
Ensure correct handling of the opening brace in PromQL legends.
The logic for appending the opening brace { seems incorrect. The inputValue.slice(0, openingBraceIndex + 1) will always result in { because openingBraceIndex is -1 when the brace is not present. This could lead to unexpected results. Consider simplifying the logic to ensure the brace is added only when missing.
- const newValue = "{" + inputValue.slice(0, openingBraceIndex + 1) + option + "}";
+ const newValue = openingBraceIndex === -1 ? "{" + option + "}" : inputValue.slice(0, openingBraceIndex + 1) + option + "}";Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| // Find the index of the last opening brace '{' | |
| const openingBraceIndex = inputValue.lastIndexOf("{"); | |
| const newValue = | |
| inputValue.slice(0, openingBraceIndex + 1) + option + "}"; | |
| return newValue; | |
| //if { is not present add it at the start and than return | |
| if (openingBraceIndex === -1) { | |
| const newValue = | |
| "{" + inputValue.slice(0, openingBraceIndex + 1) + option + "}"; | |
| return newValue; | |
| } else { | |
| const newValue = | |
| inputValue.slice(0, openingBraceIndex + 1) + option + "}"; | |
| return newValue; | |
| } | |
| // Find the index of the last opening brace '{' | |
| const openingBraceIndex = inputValue.lastIndexOf("{"); | |
| //if { is not present add it at the start and than return | |
| if (openingBraceIndex === -1) { | |
| const newValue = "{" + option + "}"; | |
| return newValue; | |
| } else { | |
| const newValue = | |
| inputValue.slice(0, openingBraceIndex + 1) + option + "}"; | |
| return newValue; | |
| } |
ktx-abhay
force-pushed
the
fix/dashboard-promql-legend-issue
branch
2 times, most recently
from
472d697
to
8abb74e
Compare
ktx-vaidehi
force-pushed
the
fix/dashboard-promql-legend-issue
branch
3 times, most recently
from
bce4679
to
3e42178
Compare
ktx-vaidehi
force-pushed
the
fix/dashboard-promql-legend-issue
branch
from
3e42178
to
5b58020
Compare
taimingl
pushed a commit
that referenced
this pull request
May 30, 2024
…ith { (#3523)
When a user directly selects anything from the dropdown, it incorrectly
puts the value in the Legend config in dashboard's add panel config for
PromQL.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved input handling in the configuration panel to ensure proper
formatting of values.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user directly selects anything from the dropdown, it incorrectly puts the value in the Legend config in dashboard's add panel config for PromQL.
Summary by CodeRabbit