Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #129 (from release-scripts repo): Handle FIREBASE_CONFIG_* constants to allow for one release candidate #19941

Closed

Conversation

JayVivarekar
Copy link
Member

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: This draft PR is created to get help in debugging the frontend coverage issue caused by code added to remove firebase constants from the codebase.
  3. (For bug-fixing PRs only) The original bug occurred because: [Explain what
    the cause of the bug was, and which PR introduced it]

Essential Checklist

  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have followed the instructions for making a code change.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
  • The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Testing doc (for PRs with Beam jobs that modify production server data)

  • A testing doc has been written: ... (ADD LINK) ...
  • (To be confirmed by the server admin) All jobs in this PR have been verified on a live server, and the PR is safe to merge.

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

Copy link

oppiabot bot commented Mar 13, 2024

Hi @JayVivarekar, can you complete the following:

  1. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
    Thanks!

Copy link

oppiabot bot commented Mar 13, 2024

Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders.
Also @JayVivarekar, please make sure to fill in the server jobs form for the new job or feature to be tested on the backup server. This PR can be merged only after the test run is successful. Please refer to this guide for details.
Thanks!

@oppiabot oppiabot bot added the PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. label Mar 13, 2024
@JayVivarekar JayVivarekar changed the title Fix #129 (from release-scripts repo) Handle FIREBASE_CONFIG_* constants to allow for one release candidate Fix #129 (from release-scripts repo): Handle FIREBASE_CONFIG_* constants to allow for one release candidate Mar 13, 2024
@seanlip seanlip removed their assignment Mar 21, 2024
@seanlip
Copy link
Member

seanlip commented Mar 21, 2024

@JayVivarekar Do you have any updates on this PR, per our recent discussion? (Did you manage to sort out the mocking issue?) Thanks!

@vojtechjelinek vojtechjelinek removed their assignment Mar 23, 2024
Copy link

oppiabot bot commented Mar 30, 2024

Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Mar 30, 2024
@DubeySandeep DubeySandeep removed their assignment Mar 30, 2024
@oppiabot oppiabot bot removed the stale label Mar 30, 2024
Copy link

oppiabot bot commented Apr 6, 2024

Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Apr 6, 2024
@oppiabot oppiabot bot removed the stale label Apr 9, 2024
Copy link

oppiabot bot commented Apr 16, 2024

Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Apr 16, 2024
@oppiabot oppiabot bot closed this Apr 20, 2024
@JayVivarekar JayVivarekar reopened this May 18, 2024
@oppiabot oppiabot bot removed the stale label May 18, 2024
Copy link

oppiabot bot commented May 18, 2024

Hi @JayVivarekar, can you complete the following:

  1. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
    Thanks!

Copy link

oppiabot bot commented May 27, 2024

Hi @JayVivarekar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label May 27, 2024
@oppiabot oppiabot bot closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants