Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Move C++ and core functionality into a separate module #8138

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndrewShkrob
Copy link
Member

Move C++/core into an organicmaps module

Pros:

  • Separate UI and core parts of the project
  • Having an SDK module that could be used by other apps/developers
  • Possibility for development of standalone apps for other platforms like Android Automotive and Wear OS
  • Other pros of modules

Cons:

  • Huge diff
  • Impossible to implement everything under one PR
  • Implementing this feature is going to be a long-term project

This is the very first PR that aims to only move the code (and some resources) into a separate module.

Signed-off-by: Andrew Shkrob <andrew.shkrob.social@yandex.by>
@biodranik
Copy link
Member

I'm not sure if I got the idea of this refactoring right. Now the code looks more complex, and some new classes were added...

So... what is the main goal(s)? Was it discussed somewhere already? Is it the best way to reach the discussed goals?

@pastk pastk requested a review from vng May 13, 2024 08:37
@rtsisyk
Copy link
Contributor

rtsisyk commented May 15, 2024

What is the goal of this refactoring?

@AndrewShkrob
Copy link
Member Author

What is the goal of this refactoring?

As I already pointed out in the description of the PR, the main goal is to split our source base into core module (sdk) and app module.
I want to add support for Android Automotive which requires a module structure of the project because AAOS app must be a standalone application which is impossible to achieve with the current structure.

@biodranik
Copy link
Member

Can AAOS app be started independently, and refactorings/moving of sources be implemented only when required? Focusing now on the SDK structure may complicate things and development.

@rtsisyk rtsisyk self-assigned this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android development Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants