Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Add setting for change map language. #8187

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

krozhdestvenski
Copy link
Contributor

Issue
#391

Solution
Map Language setting is added:
image

On click we can see language selection list
image

After select language it applies to the map (interface language = system language)
image

Signed-off-by: Kiryl Razhdzestvenski <kirill.rozh@gmail.com>
Signed-off-by: Kiryl Razhdzestvenski <kirill.rozh@gmail.com>
@Jean-BaptisteC Jean-BaptisteC changed the title Add setting for change map language. [android] Add setting for change map language. May 16, 2024
Signed-off-by: Kiryl Razhdzestvenski <kirill.rozh@gmail.com>
Copy link
Member

@Jean-BaptisteC Jean-BaptisteC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove alternative language for map language

@biodranik
Copy link
Member

Remove alternative language for map language

Good point. alt_name, old_name, int_name, default "languages" should be removed.

@krozhdestvenski
Copy link
Contributor Author

Remove alternative language for map language
Good point. alt_name, old_name, int_name, default "languages" should be removed.

Sorry, but i don't understand, what do you mean... Can you show it in code?

Signed-off-by: Kiryl Razhdzestvenski <kirill.rozh@gmail.com>
@biodranik
Copy link
Member

Sorry, but i don't understand, what do you mean... Can you show it in code?

Please check coding/string_utf8_multilang.cpp and filter out not needed items from the language list.

@krozhdestvenski
Copy link
Contributor Author

Sorry, but i don't understand, what do you mean... Can you show it in code?

Please check coding/string_utf8_multilang.cpp and filter out not needed items from the language list.

Map languages list is initialisated exactly from this file...
Or you mean, that some languages from this file can't be chosen for the map? In this case: by what attribute can this be understood?

@biodranik
Copy link
Member

Or you mean, that some languages from this file can't be chosen for the map? In this case: by what attribute can this be understood?

I've listed the language names that are not languages, but artificial OSM-defined tags. They should be removed.

Signed-off-by: Kiryl Razhdzestvenski <kirill.rozh@gmail.com>
@krozhdestvenski
Copy link
Contributor Author

Or you mean, that some languages from this file can't be chosen for the map? In this case: by what attribute can this be understood?

I've listed the language names that are not languages, but artificial OSM-defined tags. They should be removed.

completed in this and in the alternative impl.

@krozhdestvenski
Copy link
Contributor Author

maybe, it's better to close this PR and work in #8237?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants