[ios] Improve TTS voice selection #8196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabwu
force-pushed
the
tts
branch
2 times, most recently
from
c444859
to
9bba62f
Compare
|
I've changed two more things:
|
biodranik
reviewed
May 20, 2024
This commit allows a user to select more voices (e.g. English (United States), English (India)). Currently, it's only possible to select a subset of the available voices on iOS. For example, if a user selects English as TTS language, an Australian voice is selected because en_AU comes before en_US in the voice list of iOS. Fixes organicmaps#6840 Fixes organicmaps#3222 Fixes organicmaps#2178 Signed-off-by: Fabian Wüthrich <me@fabwu.ch>
biodranik
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows a user to select more voices (e.g. English (United States), English (India)). Currently, it's only possible to select a subset of the available voices on iOS. For example, if a user selects English as TTS language, an Australian voice is selected because en_AU comes before en_US in the voice list of iOS.
Fixes #6840
Fixes #3222
Fixes #2178
Fixes #7604