DOC: Fixed PR01 for pandas.Series.cat #58750
Open
+38
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #58504
Fixes PR01 for
I couldn't figure out how to fix PR02. If I'm getting it right, numpydoc detects PR02 errors if there are parameters described in the docstring that are not in the method signature. I dug into how the docstring validation works and found that it uses the signature of f defined in
pandas/core/accessor.py
instead of the actual signature of the methods defined inpandas/core/arrays/categorical.py
For reference, here's that delegator:
So PR02 is always detected if the method has any parameters. How should this be handled?