Remove the worker dev dep build cache in packaging #9532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
There is currently a possible race condition in requests where it's possible for them to run in a different order on the main thread then they were sent from the worker thread. This causes an issue with dev dep requests as they have a build cache that reduces the information on the request if it's already run before to reduce overall serialisation time.
This PR removes the build cache from just the PackageRunner dev dep requests and leaves it on the Transformation ones. The thinking here is that the Packaging ones don't get a lot of benefit from the cache but seem to be the only ones that fail. This isn't ideal but I think it should make the error pretty much disappear for very little performance loss.
✔️ PR Todo