Fix windows stack overflow with larger stack red_zone #9693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking a look, somehow Windows is still failing on CI though? |
mischnic
force-pushed
the
bump-swc
branch
2 times, most recently
from
ac92e7a
to
8d7eabf
Compare
|
Looks like it's passing now with a larger red zone of 32 KiB. |
mischnic
pushed a commit
that referenced
this pull request
May 8, 2024
mischnic
pushed a commit
that referenced
this pull request
May 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
* Bump swc, enable stacker feature Bump swc * Adapt for breaking swc AST change * Support testing with Miri * Grow stack when visiting expressions * WIP add example * Revert "WIP add example" This reverts commit d4dba2c. * Add swc update script * Update test fixtures * Fix windows stack overflow with larger stack red_zone (#9693) * Bump swc * Bump a few crates for vulnerabilites * Bump swc * Fix esm2js transform when export destructuring --------- Co-authored-by: Jon de la Motte <jondlm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the stack overflow issues with windows on the
bump-swcPR #9574.