chore: show toast info banner when save hotkey used with no changes #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I'm not sure we should display anything at all here tbh. I think most apps would simply do nothing. Notifying the user of an event that didn't happen feels unnecessary. What do you think? Might just be a matter of returning |
JessChowdhury
force-pushed
the
chore/beta/save-hotkey
branch
from
1d4183e
to
f5ea733
Compare
I updated the PR. Returning nothing or returning |
jacobsfletch
approved these changes
May 21, 2024
JessChowdhury
added a commit
that referenced
this pull request
May 21, 2024
…h no changes (#6365) ## Description Related issue [#214](payloadcms/payload-3.0-demo#214) (3.0). Using the `cmd+s` hotkey in the Edit Document view was opening the _browser_ save dialogue when no changes had been made. This change triggers a toast info banner with `No changes to save` and adds translated string for other languages. PR for 3.0 is [here](#6366). - [X] I have read and understand the [CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md) document in this repository. ## Type of change - [X] Chore (non-breaking change which does not add functionality) ## Checklist: - [X] Existing test suite passes locally with my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #214.
If hotkey
cmd+sis pressed when the document has no changes, it opens the browser save dialogue. This change displays a toast info banner withNo changes to save.PR for 2.0 is here.
Type of change
Checklist: