Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value #17061

Draft
wants to merge 4 commits into
base: 11.x
Choose a base branch
from

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented May 16, 2024

Changes in this pull request

Implicitly nullable parameter declarations are deprecated in PHP 8.4
CS-Fixer can fix them by setting a specific rule

Draft: Just to quickly check how many automated changes it would trigger
Still need to manually fix and check all the hardcoded in phpdoc eg. * @method string someMethod(int $param = null)

Additional info

See also symfony/symfony#53612

Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 marked this pull request as ready for review May 16, 2024 08:48
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.9% Duplication on New Code

See analysis details on SonarCloud

@kingjia90 kingjia90 marked this pull request as draft May 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant