Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Generic Execution Engine #17062

Merged
merged 20 commits into from
Jun 4, 2024
Merged

Introduce Generic Execution Engine #17062

merged 20 commits into from
Jun 4, 2024

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented May 16, 2024

Changes in this pull request

Added generic execution engine

Additional info

For discussion:

  • How to handle storage of succeeded/processed elements? Is a column in the table, that gets reset enough? Or should it be stored in a separate table? - It is ok for now
  • Log to different/separate file? - added separate channel
  • Does it make sense to execute step 2 after step 1 was executed? Even with continue on error option? Theoretically you could also achieve this with 2 different jobs - not needed right now
  • Create events for different actions, e.g. job startet, job completed, job state, ...

Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lukmzig lukmzig marked this pull request as ready for review June 3, 2024 13:13
@lukmzig lukmzig changed the title [WIP] Introduce generic execution engine Introduce Generic Execution Engine Jun 3, 2024
@lukmzig lukmzig merged commit e3d6e19 into 11.x Jun 4, 2024
19 checks passed
@lukmzig lukmzig deleted the generic-execution-engine branch June 4, 2024 06:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
@fashxp fashxp added this to the 11.3.0 milestone Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants