expression: update md5 hash to use hex (#53003)

close #53018
pingcap · May 7, 2024 · 013a4e6 · 013a4e6
1 parent 96f9797
commit 013a4e6
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/pkg/expression/builtin_encryption.go b/pkg/expression/builtin_encryption.go
@@ -24,6 +24,7 @@ import (
 	"crypto/sha256"
 	"crypto/sha512"
 	"encoding/binary"
+	"encoding/hex"
 	"fmt"
 	"hash"
 	"io"
@@ -635,7 +636,8 @@ func (b *builtinMD5Sig) evalString(ctx EvalContext, row chunk.Row) (string, bool
 		return "", isNull, err
 	}
 	sum := md5.Sum([]byte(arg)) // #nosec G401
-	hexStr := fmt.Sprintf("%x", sum)
+	hexStr := hex.EncodeToString(sum[:])
+
 	return hexStr, false, nil
 }
 

diff --git a/pkg/expression/builtin_encryption_test.go b/pkg/expression/builtin_encryption_test.go
@@ -16,6 +16,7 @@ package expression
 
 import (
 	"context"
+	"crypto/md5"
 	"encoding/hex"
 	"fmt"
 	"strings"
@@ -498,6 +499,25 @@ func TestMD5Hash(t *testing.T) {
 	require.NoError(t, err)
 }
 
+func MD5HashOld(arg string) string {
+	sum := md5.Sum([]byte(arg))
+	return fmt.Sprintf("%x", sum)
+}
+
+func MD5HashNew(arg string) string {
+	sum := md5.Sum([]byte(arg))
+	return hex.EncodeToString(sum[:])
+}
+
+func BenchmarkMD5Hash(b *testing.B) {
+	b.ResetTimer()
+	b.ReportAllocs()
+	for i := 0; i < b.N; i++ {
+		MD5HashOld("abc")
+		//MD5HashNew("abc")
+	}
+}
+
 func TestRandomBytes(t *testing.T) {
 	ctx := createContext(t)