Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move util into pkg/util #47158

Closed
wants to merge 8 commits into from
Closed

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Sep 21, 2023

What problem does this PR solve?

Issue Number: ref #41241

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hawkingrei and others added 5 commits September 21, 2023 10:11
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

Hi @lcwangchao. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 21, 2023
@tiprow
Copy link

tiprow bot commented Sep 21, 2023

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #47158 (1b5927a) into master (71e5858) will decrease coverage by 0.3466%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47158        +/-   ##
================================================
- Coverage   73.0051%   72.6586%   -0.3466%     
================================================
  Files          1338       1359        +21     
  Lines        399462     405751      +6289     
================================================
+ Hits         291628     294813      +3185     
- Misses        88992      92198      +3206     
+ Partials      18842      18740       -102     
Flag Coverage Δ
integration 30.7471% <ø> (?)
unit 72.9971% <ø> (-0.0081%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9620% <ø> (ø)
br 48.7348% <ø> (-4.3660%) ⬇️

@lcwangchao
Copy link
Collaborator Author

/retest

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-21 08:30:51.997194172 +0000 UTC m=+765417.964782223: ☑️ agreed by hawkingrei.

@easonn7
Copy link

easonn7 commented Sep 21, 2023

/approve

There is no sysvar change.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: easonn7, hawkingrei
Once this PR has been reviewed and has the lgtm label, please assign bb7133, zanmato1984 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lcwangchao
Copy link
Collaborator Author

close for #47123 will include this change

@lcwangchao lcwangchao closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-1-more-lgtm ok-to-test release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants