Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refine executor code #52959

Merged
merged 5 commits into from May 7, 2024

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #52903

Problem Summary:

What changed and how does it work?

  • move join exec related code to tidb/pkg/executor/join
  • move union exec related code to tidb/pkg/executor/union(to avoid cycle import)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none do-not-merge/invalid-title size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2024
@windtalker windtalker changed the title Refine executor code executor: refine executor code Apr 28, 2024
Copy link

tiprow bot commented Apr 28, 2024

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 94.05204% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 55.8127%. Comparing base (2343c54) to head (db38e17).
Report is 14 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52959         +/-   ##
=================================================
- Coverage   72.3920%   55.8127%   -16.5793%     
=================================================
  Files          1483       1625        +142     
  Lines        429021     605978     +176957     
=================================================
+ Hits         310577     338213      +27636     
- Misses        99142     244513     +145371     
- Partials      19302      23252       +3950     
Flag Coverage Δ
integration 37.0382% <89.8389%> (?)
unit 71.4133% <87.8562%> (+0.1829%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5196% <61.4583%> (+5.3072%) ⬆️

@windtalker
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Apr 29, 2024

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@windtalker
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Apr 29, 2024

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@@ -0,0 +1,232 @@
// Copyright 2015 PingCAP, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2015 -> 2024?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-06 09:22:23.291521736 +0000 UTC m=+867497.048657313: ☑️ agreed by guo-shaoge.
  • 2024-05-07 02:32:31.435231818 +0000 UTC m=+929305.192367390: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot merged commit de92425 into pingcap:master May 7, 2024
21 checks passed
@windtalker windtalker deleted the refine_executor_code branch May 7, 2024 06:49
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this pull request May 7, 2024
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reorg join executor's code
3 participants