planner: fix index merge shouldn't push partial limit down when index plans are keep ordered (#52979) #53149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
ok-to-test
release-note
sig/planner
Merged
13 tasks
Defined2014
approved these changes
May 10, 2024
wuhuizuo
reviewed
May 10, 2024
pkg/planner/core/task.go
Outdated
| @@ -893,6 +895,10 @@ func (p *PhysicalLimit) attach2Task(tasks ...task) task { | |||
| cop.idxMergePartPlans = limitChildren | |||
| t = cop.convertToRootTask(p.SCtx()) | |||
| sunk = p.sinkIntoIndexMerge(t) | |||
| } else { | |||
| // when there are some limitations, just sink the limit upon the index merge reader. | |||
| t = cop.ConvertToRootTask(p.SCtx()) | |||
Signed-off-by: AilinKid <314806019@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53149 +/- ##
================================================
Coverage ? 71.1671%
================================================
Files ? 1463
Lines ? 420767
Branches ? 0
================================================
Hits ? 299448
Misses ? 100862
Partials ? 20457
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AilinKid
approved these changes
May 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #52979
What problem does this PR solve?
Issue Number: close #52947
Problem Summary:
#52947 (comment)
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.