Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix negative consumedbyte for hashRowcontainer (#50843) #53344

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50843

What problem does this PR solve?

Issue Number: close #50841

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that goroutine leak when hashJoin triggered spill and sql failed

Copy link

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-17 03:38:11.852741731 +0000 UTC m=+1797245.609877297: ☑️ agreed by guo-shaoge.
  • 2024-05-17 03:38:29.423688832 +0000 UTC m=+1797263.180824406: ☑️ agreed by XuHuaiyu.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5-20231229-v6.5.6@72f3dd2). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20231229-v6.5.6     #53344   +/-   ##
================================================================
  Coverage                               ?   73.6500%           
================================================================
  Files                                  ?       1088           
  Lines                                  ?     349670           
  Branches                               ?          0           
================================================================
  Hits                                   ?     257532           
  Misses                                 ?      75598           
  Partials                               ?      16540           

@ti-chi-bot ti-chi-bot bot merged commit 4d7d311 into pingcap:release-6.5-20231229-v6.5.6 May 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants