Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment for overlooked nested lookups in chain breaks #2322

Merged
merged 2 commits into from
May 31, 2024

Conversation

eldair
Copy link
Contributor

@eldair eldair commented Feb 4, 2024

I have adjusted chain breaks for nested lookups which were overlooked in previous pull request. Also the break should now be consistent between Test::foo()->, (new Test())->, $test['foo'] etc.

Copy link
Collaborator

@cseufert cseufert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM

Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, sorry about the delay @eldair!

@czosel czosel merged commit 6f9790e into prettier:main May 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants