-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Feat: Add clusterTLSConfigs to the Alertmanager CRD #6489
base: main
Are you sure you want to change the base?
[WIP] Feat: Add clusterTLSConfigs to the Alertmanager CRD #6489
Conversation
Questions:
|
Requesting review: @simonpasquier @ArthurSens @nicolastakashi @slashpai. Some concepts are still not clear to me, especially stuff that is not directly related to the code itself but the cluster tls config in general. I think the review will help a lot. Kindly bear with me, if I am not up to speed! |
3a43bfe
to
7347499
Compare
Background: Problem with De-duplication: Alternative Approach: |
Can you rebase on top of main to get #6612? |
7347499
to
e22756f
Compare
I reckon we also need to add tests, I will get to it once we are happy with the current changes. |
Currently caught up with other things, will get back to this PR once things higher on my priority list are done! |
Description
This PR adds mTLS config to AlertManager, allowing user to configure gossip between alert managers using mTLS for authentication.
Closes: #4241
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.