-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote): add support prometheus remote write/read ProxyConfig #6512
base: main
Are you sure you want to change the base?
feat(remote): add support prometheus remote write/read ProxyConfig #6512
Conversation
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Thanks for looking into it! It'd be better to fix #6523 first. It would be super dope if you tackle first :) |
Got it. I'll add a PR to fix it. |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@simonpasquier @slashpai #6541 have been merged. |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Please re-check it. Thanks. |
Thanks for revisiting the PR! With the latest changes to pkg/assets, I suggest to load the referenced secrets referenced by the proxy config in |
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
add support prometheus remote write/read ProxyConfig
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.