Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: add py313 HTTPStatus aliases #11935

Merged
merged 2 commits into from
May 18, 2024
Merged

http: add py313 HTTPStatus aliases #11935

merged 2 commits into from
May 18, 2024

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
srittau
srittau reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't these need to be version gated like e.g. IM_A_TEAPOT below?

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented May 17, 2024 •
edited

Yes, it should... I'll also look into why CI didn't fail.

Edit: looks like it's getting ignored by the same logic that avoids flagging missing instance variables when we can't find them on the type

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 4951246 into python:main May 18, 2024
54 checks passed
@hauntsaninja hauntsaninja deleted the http branch May 18, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hauntsaninja @srittau