gzip: change type of undocumented constants #11943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were changed to str in py313
This comment has been minimized.
This comment has been minimized.
| READ: Literal[1] # undocumented | ||
| WRITE: Literal[2] # undocumented | ||
| READ: object # undocumented | ||
| WRITE: object # undocumented |
There was a problem hiding this comment.
We also need to change the type of the GzipFile.mode attribute on line 89 below. I wouldn't be opposed to adding the new exact values (rb and wb here) instead of using object.
There was a problem hiding this comment.
Thanks, fixed
I've kept it as object since it makes it more obvious if your code would fail cross-version (almost all users only type check on one version) / since CPython is clearly treating it as implementation detail that has changed in practice
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were changed to str in py313