-
Notifications
You must be signed in to change notification settings - Fork 1k
test(chatlog): add test for chatlog module #5935
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for adding more tests to qTox, two questions though:
|
Running on Travis, the test aborts after just a few ms: but running locally, the test runs for a little over 7s. This might be because the test spawn a graphical window on my system, which travis probably doesn't support. I don't think running graphical CI is something we can support anytime soon :( Is it possible to test scroll behaviour only through examining class state, without requiring a graphical backend? Also running with my PR #5939, scroll behaviour seems to me to work correctly, but the test fails with:
do you think this is a test issue? or is there a bug with #5939? |
Without graphical backend run this test possible if separate the Chatlog on logical and graphic module. Otherwise this can be used for manual testing. In you case scroll value before insert messages - 891, and value after insert - 1435. It seems that the slider was in the center, and after inserting attached to the bottom. |
This change is