Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Refactor/core cmake #6227

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Refactor/core cmake #6227

wants to merge 13 commits into from

Conversation

sudden6
Copy link
Member

@sudden6 sudden6 commented Sep 2, 2020

Working on putting Core in a separate cmake project.


This change is Reviewable

@sudden6 sudden6 changed the title [WIP] Refactor/core cmake Refactor/core cmake Sep 20, 2020
@sudden6
Copy link
Member Author

sudden6 commented Sep 20, 2020

Making core an independent submodule of qTox is now complete.

Testing Audio and Video calls didn't show any regressions so far.

Since core is now independent, I think we should move unit tests that test only core functionality there too, but I want to do this in a separate PR since this one is quite big already.

Copy link
Contributor

@bodwok bodwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


src/widget/form/groupchatform.cpp, line 313 at r1 (raw file):

headWidget->updateMuteMicButton(call != nullptr, !muteState);

here checks call != nullptr, but earlier called call->setMuteMic(!muteState) and call cannot be nullptr


src/widget/form/groupchatform.cpp, line 322 at r1 (raw file):

headWidget->updateMuteVolButton(call != nullptr, !muteState);

same


src/widget/form/groupchatform.cpp, line 335 at r1 (raw file):

headWidget->updateMuteMicButton(call != nullptr, call->getMuteMic());

here call can be nullptr and when calling call->getMuteMic() will result in a segfault


src/widget/form/groupchatform.cpp, line 336 at r1 (raw file):

headWidget->updateMuteVolButton(call != nullptr, call->getMuteVol());

same


src/widget/form/groupchatform.cpp, line 342 at r1 (raw file):

(call != nullptr)

move the check call != nullptr in onMicMuteToggle() ?


src/widget/form/groupchatform.cpp, line 353 at r1 (raw file):

(call != nullptr)

same

Copy link
Contributor

@bodwok bodwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


src/widget/form/groupchatform.cpp, line 335 at r1 (raw file):

Previously, bodwok wrote…
headWidget->updateMuteMicButton(call != nullptr, call->getMuteMic());

here call can be nullptr and when calling call->getMuteMic() will result in a segfault

for test: start group audio call with participant, end call

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants